[WIP] Avoid dependency on dynamic attribute lookup in drivers#7845
Draft
jenshnielsen wants to merge 47 commits intomicrosoft:mainfrom
Draft
[WIP] Avoid dependency on dynamic attribute lookup in drivers#7845jenshnielsen wants to merge 47 commits intomicrosoft:mainfrom
jenshnielsen wants to merge 47 commits intomicrosoft:mainfrom
Conversation
jenshnielsen
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7845 +/- ##
==========================================
- Coverage 59.87% 58.85% -1.02%
==========================================
Files 352 352
Lines 31872 31927 +55
==========================================
- Hits 19083 18792 -291
- Misses 12789 13135 +346 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jenshnielsen
force-pushed
the
better_instrument_types
branch
from
d98bf90 to
9b2dfb4
Compare
Support looking up any Insturment as long as the name is know not just the same as the bound instrument
jenshnielsen
force-pushed
the
better_instrument_types
branch
from
9b2dfb4 to
44fedd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not to merge directly. This pr disables delegate attributes getattr for type checking and updates drivers to not depend on dynamic attributes and fix any issues discovered as part of this. This pr will not be merged directly but cherry picked as it makes sense